Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S390x rpm list maintenance support #3203

Closed
wants to merge 4 commits into from
Closed

S390x rpm list maintenance support #3203

wants to merge 4 commits into from

Conversation

cfilleke
Copy link
Member

@cfilleke cfilleke commented Apr 17, 2024 •
edited
Loading

What this PR does / why we need it:

Add support for bazeldnf to maintain the rpm lists for s390x in BUILD.bazel

Add configurations necessary for bazeldnf to generate the rpm lists in WORKSPACE and BUILD.bazel, using the information for how to maintain these lists in .bazelrc, repo.yaml and hack/build/rpm-defs.sh as described in #3089 and #3090

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3202

Special notes for your reviewer:

@awels @dhiller @alicefr I am planning to

  • squash & sign off the commits
  • send a note to the group
  • mention at community mtg

Release note:

kind/enhancement

@kubevirt-bot kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 17, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Apr 17, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign aglitke for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • 5254425 Merge branch 'kubevirt:main' into s390x-rpms
  • 04bfed3 Merge branch 'kubevirt:main' into s390x-rpms
  • 7b2233e Merge branch 'kubevirt:main' into s390x-rpms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

Hi @cfilleke. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added size/M release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 17, 2024
@awels
Copy link
Member

awels commented Apr 17, 2024

Did a quick review of the changes, and I see no real issues here. Only that there will be no support for importing from oVirt imageio and VMWare due to there not being dependencies for s390x for those sources.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfilleke cfilleke marked this pull request as draft May 22, 2024 18:16
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@cfilleke cfilleke mentioned this pull request May 22, 2024
Merged
@cfilleke cfilleke closed this May 24, 2024
@cfilleke
Copy link
Member Author

superseded by #3286

@cfilleke cfilleke deleted the s390x-rpms branch May 24, 2024 15:07
@cfilleke cfilleke mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alromeros alromeros Awaiting requested review from alromeros

@ShellyKa13 ShellyKa13 Awaiting requested review from ShellyKa13

Assignees
No one assigned
Labels
dco-signoff: no Indicates the PR's author has not DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide RPM support for s390x platform
3 participants
@cfilleke @kubevirt-bot @awels